-
Notifications
You must be signed in to change notification settings - Fork 614
Support initialDirectory and title in Linux' showOpenDialog #496
Conversation
I'm going to check this on my 14.10 VM |
I was able to compile and run this on my 14.10 VM (32 Bit). Looks good so far. |
I still wasn't able to compile this on my 14.10 VM (32 Bit), even though I ran I'm also not too experienced with native code and that's why I honestly don't know how to implement @ingorichter As you managed building it, could you just make sure that running |
@marcelgerber let me check tomorrow if we have any occurrences where we pass |
@@ -164,15 +164,21 @@ int32 ShowOpenDialog(bool allowMultipleSelection, | |||
CefRefPtr<CefListValue>& selectedFiles) | |||
{ | |||
GtkWidget *dialog; | |||
const char* dialog_title = chooseDirectory ? "Open Directory" : "Open File"; | |||
// const char* dialog_title = chooseDirectory ? "Open Directory" : "Open File"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can get rid of this line, since the caller provides the specific title.
Passing |
Done. Ready for merge. |
Support initialDirectory and title in Linux' showOpenDialog
Thanks @marcelgerber. Merged. |
Fwiw, here's the Trello card for missing |
Support initialDirectory and title in Linux' showOpenDialog
For adobe/brackets#10297
I weren't able to build this due to various errors (in a Ubuntu 14.10 VM), not even on top of the
linux-1547
branch.I also don't know what to do with
fileTypes
- it currently doesn't work either.